Page MenuHomePhabricator

Yet another line number fix ๐Ÿ˜”
ClosedPublic

Authored by cdecarolis on Oct 20 2020, 3:56 PM.

Details

Summary

There was a stray comment in the backfill partitions example I saw while scrolling.

Test Plan

before:


after:

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cdecarolis retitled this revision from backfill fix to Yet another line number fix ๐Ÿ˜”.Oct 20 2020, 3:58 PM
cdecarolis edited the summary of this revision. (Show Details)
cdecarolis edited the test plan for this revision. (Show Details)
cdecarolis added a reviewer: yuhan.
docs/next/src/pages/overview/scheduling-partitions/backfill.mdx
22

To guard against this in the future, would we be able to add a marker and do something like

startAfter:start_partition_set_definition_marker
endBefore:end_partition_definition_marker_0
docs/next/src/pages/overview/scheduling-partitions/backfill.mdx
22

So the reason that we use line numbers here and not markers is that the code example is enclosed inside a "larger" marker. If we were to do that, we would end up with the enclosed marker displaying in the other code example.

This revision is now accepted and ready to land.Oct 20 2020, 5:00 PM