Page MenuHomePhabricator

[dagit] Create instance routes
ClosedPublic

Authored by dish on Oct 20 2020, 3:22 PM.

Details

Summary

Move instance-level sections of Dagit to /instance paths.

  • /assets/... -> /instance/assets/...
  • /scheduler -> /instance/scheduler
  • /runs?... -> /instance/runs?...

I also created a FallthroughRoot to perform redirects for the existing routes, in case of any paths that I missed converting, or in case users have bookmarks. In the future, these should probably be cleaned up.

There are a couple other paths to move to the /instance path space as well, but this gets things moving.

Test Plan

View all affected routes in Dagit, verify correct loading, rendering, redirects.

Diff Detail

Repository
R1 dagster
Branch
dish-instance-route (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2020, 3:28 PM
Harbormaster failed remote builds in B19839: Diff 24067!
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 20 2020, 3:48 PM
Harbormaster failed remote builds in B19840: Diff 24069!
dish requested review of this revision.Oct 20 2020, 5:04 PM
This revision is now accepted and ready to land.Oct 20 2020, 6:08 PM
dish retitled this revision from RFC [dagit] Create instance routes to [dagit] Create instance routes.Oct 20 2020, 6:55 PM
This revision was automatically updated to reflect the committed changes.