Page MenuHomePhabricator
Differential D4822

serialization safety
ClosedPublic
Actions

Authored by max on Oct 19 2020, 10:50 PM.

Details

Reviewers
bob
Commits
R1:77f3ec8fba9e: serialization safety
Summary

Make dbt result objects pickleable

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Branch
fix-dbt-serialization
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

max created this revision.Oct 19 2020, 10:50 PM
max mentioned this in D4710: Adds example dbt project..
Harbormaster completed remote builds in B19816: Diff 24041.Oct 19 2020, 11:13 PM
max requested review of this revision.Oct 19 2020, 11:13 PM
bob added inline comments.Oct 20 2020, 2:49 PM
python_modules/libraries/dagster-dbt/dagster_dbt/types.py
24

The parser.isoparse exists to produce datetime.datetime types. Why was it removed?

max updated this revision to Diff 24065.Oct 20 2020, 2:59 PM

fix type hints

bob accepted this revision.Oct 20 2020, 3:05 PM

Macro thumbsup:

This revision is now accepted and ready to land.Oct 20 2020, 3:05 PM
Harbormaster completed remote builds in B19837: Diff 24065.Oct 20 2020, 3:21 PM
Closed by commit R1:77f3ec8fba9e: serialization safety (authored by max). · Explain WhyOct 20 2020, 3:25 PM
This revision was automatically updated to reflect the committed changes.
max added a commit: R1:77f3ec8fba9e: serialization safety.

Revision Contents
Changeset List

PathSize
python_modules/
libraries/
dagster-dbt/
dagster_dbt/
cli/
31 lines
rpc/
14 lines
68 lines
dagster_dbt_tests/
cli/
6 lines
rpc/
6 lines
6 lines

Diff 24041

View Options

python_modules/libraries/dagster-dbt/dagster_dbt/cli/types.py

Loading...
View Options

python_modules/libraries/dagster-dbt/dagster_dbt/rpc/types.py

Loading...
View Options

python_modules/libraries/dagster-dbt/dagster_dbt/types.py

Loading...
View Options

python_modules/libraries/dagster-dbt/dagster_dbt_tests/cli/test_types.py

Loading...
View Options

python_modules/libraries/dagster-dbt/dagster_dbt_tests/rpc/test_types.py

Loading...
View Options

python_modules/libraries/dagster-dbt/dagster_dbt_tests/test_types.py

Loading...