Page MenuHomePhabricator

[experiment] dagit gevent tweaks
DraftPublic

Authored by alangenfeld on Oct 19 2020, 9:07 PM.
This draft revision will be sent for review once this build passes: Build 43496: Build.

Details

Reviewers
None
Summary

Changes:

  • make each graphql requests its own greenlet
  • yield greenlet while waiting on database requests to postgres

Observations:

  • later graphql requests can now resolve while waiting on db requests
  • errors from unexpected interleving (errors with postgres connections)
  • actual graphql subscriptions broken
Test Plan

n/a

Diff Detail

Repository
R1 dagster
Branch
gevent (branched from master)
Lint
Lint Warnings
Unit
No Unit Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 19 2020, 9:28 PM
Harbormaster failed remote builds in B19803: Diff 24027!
alangenfeld edited the summary of this revision. (Show Details)

add lock