Details

Reviewers

alangenfeld
johann

Commits

R1:f74856e50cdf: Remove executePlan dagster-graphql call

Summary

The only remaining callsites of this were executing a plan in-process and didn't need to be using dagster-graphql in the first place. Switch those callsites over to call execute_plan directly and then remove executePlan altogether from dagster-graphql.

Test Plan

Diff Detail

Repository

R1 dagster

Branch

killtheoperator2

Lint

Lint OK

Unit

No Unit Test Coverage

Event Timeline

dgibson created this revision.Oct 19 2020, 8:43 PM

rm dagster-graphql from setup.py as well

Harbormaster failed remote builds in B19799: Diff 24022!Oct 19 2020, 9:02 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 19 2020, 9:09 PM

Harbormaster failed remote builds in B19801: Diff 24024!

Harbormaster failed remote builds in B19827: Diff 24054!Oct 20 2020, 1:23 AM

Harbormaster completed remote builds in B19830: Diff 24057.Oct 20 2020, 1:39 AM

dgibson requested review of this revision.Oct 20 2020, 1:39 AM

sobeautiful

yeahfuckyeah

python_modules/dagster-graphql/dagster_graphql/client/mutations.py
4–6	can this not get dropped too?

This revision is now accepted and ready to land.Oct 20 2020, 4:39 PM

rebase, CHANGES.md

up, remove that class you mentinoed

Harbormaster completed remote builds in B19858: Diff 24090.Oct 20 2020, 6:42 PM

Harbormaster completed remote builds in B19863: Diff 24098.Oct 20 2020, 7:01 PM

Closed by commit R1:f74856e50cdf: Remove executePlan dagster-graphql call (authored by dgibson). · Explain WhyOct 20 2020, 7:39 PM

This revision was automatically updated to reflect the committed changes.

dgibson added a commit: R1:f74856e50cdf: Remove executePlan dagster-graphql call.

Remove executePlan dagster-graphql call
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 24090

CHANGES.md

js_modules/dagit/src/filteredSchema.generated.json

js_modules/dagit/src/schema.graphql

python_modules/dagster-graphql/dagster_graphql/cli.py

python_modules/dagster-graphql/dagster_graphql/client/mutations.py

python_modules/dagster-graphql/dagster_graphql/client/query.py

python_modules/dagster-graphql/dagster_graphql/client/util.py

python_modules/dagster-graphql/dagster_graphql/implementation/context.py

python_modules/dagster-graphql/dagster_graphql/implementation/execution/init.py

python_modules/dagster-graphql/dagster_graphql/schema/errors.py

python_modules/dagster-graphql/dagster_graphql/schema/roots.py

python_modules/dagster-graphql/dagster_graphql_tests/client_tests/test_mutations.py

python_modules/dagster-graphql/dagster_graphql_tests/client_tests/test_util.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_execution_plan.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_execution_plan.py

python_modules/dagster-graphql/dagster_graphql_tests/test_cli.py

python_modules/dagster/dagster/core/execution/api.py

python_modules/dagster/dagster/core/host_representation/init.py

python_modules/dagster/dagster/core/host_representation/external.py

python_modules/dagster/dagster/core/host_representation/repository_location.py

python_modules/dagster/dagster/utils/hosted_user_process.py

python_modules/libraries/dagster-airflow/dagster_airflow/operators/util.py

python_modules/libraries/dagster-airflow/setup.py

python_modules/libraries/dagster-dask/dagster_dask/executor.py

python_modules/libraries/dagster-dask/setup.py

python_modules/libraries/dagster-k8s/dagster_k8s/test.py

Remove executePlan dagster-graphql callClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24090

CHANGES.md

js_modules/dagit/src/filteredSchema.generated.json

js_modules/dagit/src/schema.graphql

python_modules/dagster-graphql/dagster_graphql/cli.py

python_modules/dagster-graphql/dagster_graphql/client/mutations.py

python_modules/dagster-graphql/dagster_graphql/client/query.py

python_modules/dagster-graphql/dagster_graphql/client/util.py

python_modules/dagster-graphql/dagster_graphql/implementation/context.py

python_modules/dagster-graphql/dagster_graphql/implementation/execution/__init__.py

python_modules/dagster-graphql/dagster_graphql/schema/errors.py

python_modules/dagster-graphql/dagster_graphql/schema/roots.py

python_modules/dagster-graphql/dagster_graphql_tests/client_tests/test_mutations.py

python_modules/dagster-graphql/dagster_graphql_tests/client_tests/test_util.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_execution_plan.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_execution_plan.py

python_modules/dagster-graphql/dagster_graphql_tests/test_cli.py

python_modules/dagster/dagster/core/execution/api.py

python_modules/dagster/dagster/core/host_representation/__init__.py

python_modules/dagster/dagster/core/host_representation/external.py

python_modules/dagster/dagster/core/host_representation/repository_location.py

python_modules/dagster/dagster/utils/hosted_user_process.py

python_modules/libraries/dagster-airflow/dagster_airflow/operators/util.py

python_modules/libraries/dagster-airflow/setup.py

python_modules/libraries/dagster-dask/dagster_dask/executor.py

python_modules/libraries/dagster-dask/setup.py

python_modules/libraries/dagster-k8s/dagster_k8s/test.py

Remove executePlan dagster-graphql call
ClosedPublic
Actions

Revision Contents
Changeset List

python_modules/dagster-graphql/dagster_graphql/implementation/execution/init.py

python_modules/dagster/dagster/core/host_representation/init.py