Page MenuHomePhabricator

rm DagsterKubernetesPodOperator and test infra around it
ClosedPublic

Authored by dgibson on Oct 19 2020, 7:52 PM.

Details

Summary

Why we are deleting this, as per nate:
a) Its based on vendoring an older version of Airflow, so we’re pinned to that version which has known security vulnerabilities and it does not work with newer versions, so we’ll need to rewrite this anyway for newer Airflow if/when we need it for rea
b) I don’t think we have any users on it;
c) I doubt test coverage is very good, since it involves integration testing w/ both Airflow + K8s
d) it is currently broken in master unless you configure the container that it calls in a strange way

Test Plan

BK

Diff Detail

Repository
R1 dagster
Branch
killtheoperator (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 19 2020, 8:12 PM
Harbormaster failed remote builds in B19792: Diff 24015!

test failures are transient/unrelated

As per discussion in the platform lane chat.

worth updating this with the relevant contents of - since this is a public artifact and it may be useful for someone to see why we let this go

include proactive CHANGES.md entry for this (just add (Upcoming) to the new version # section)

redparty

This revision is now accepted and ready to land.Oct 20 2020, 6:03 PM
This revision was landed with ongoing or failed builds.Oct 20 2020, 6:19 PM
This revision was automatically updated to reflect the committed changes.