Page MenuHomePhabricator

(config-scaffold 1/n) Fix config errors visualization in Dagit
ClosedPublic

Authored by sashank on Sun, Oct 18, 4:53 AM.

Details

Summary

When a solid was missing an input or config in the Playground, we incorrectly displayed that the solid had valid configuration in the "error preview" section. This diff updates the error logic to display the "invalid" state when any subconfiguration for a node is missing.

Test Plan

Fill out solid config, delete one part of the solid config that was required, verify that the solid box showed an error.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sashank added reviewers: bengotow, dish, schrockn.
sashank edited the test plan for this revision. (Show Details)

clean

This looks great! Good catch ๐Ÿ‘

This revision is now accepted and ready to land.Mon, Oct 19, 9:10 PM