Page MenuHomePhabricator

Fix helm namespace lifecycle in tests
ClosedPublic

Authored by dgibson on Oct 16 2020, 7:52 PM.

Details

Summary

I think the intention of this contextmanager is to leave the helm resources for the whole lifecycle, but currently its returning but not yielding so that doesn't happen. Make it a contextmanager so that it will wait until the end of the test to cleanup.

Test Plan

k8s integration tests now pass locally again

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.