Page MenuHomePhabricator

[dagit] Standardize font-family usage
ClosedPublic

Authored by dish on Fri, Oct 16, 5:50 PM.

Details

Summary

Resolves #3093

Standardize our fonts throughout Dagit. Makes things look a lot nicer.

  • Use the default font-family supplied by Blueprint, with -apple-system as the primary choice. For recent MacOS versions, this should be San Francisco.
  • Define a standard monospace font-family for usage everywhere, Source Code Pro. We use this in some places, but there is a fairly loose mixture of this override and the regular monospace default, which in most cases is sadly Courier New.
Test Plan

View Dagit on latest Chrome, Firefox, Safari on MacOS 10.15.7. Verify that fonts are consistent throughout Dagit.

Diff Detail

Repository
R1 dagster
Branch
dish-font-family (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

dish requested review of this revision.Fri, Oct 16, 5:57 PM

Beautiful

js_modules/dagit/src/CustomAlertProvider.tsx
74

Nit: delete?

This revision is now accepted and ready to land.Fri, Oct 16, 6:17 PM
js_modules/dagit/src/CustomAlertProvider.tsx
74

Or I guess uncomment

This revision was automatically updated to reflect the committed changes.