Paths

Table of Contentst

[k8s] Allow users to set custom labels in Pod metadata
ClosedPublic
Actions

Authored by sashank on Oct 16 2020, 3:07 PM.

Details

Reviewers

johann
alangenfeld
nate

Commits

R1:82cc272fbfe0: [k8s] Allow users to set custom labels in Pod metadata

Summary

We previously didn't allow users to set custom labels in their Pod spec metadata because we had custom labels that were causing an error. This diff updates V1PodTemplateSpec object creation to merge user defined labels and dagster defined labels.

Test Plan

updated integration test

Diff Detail

Repository

R1 dagster

Branch

fix-k8s-pods-labels

Lint

Lint OK

Unit

No Unit Test Coverage

Event Timeline

sashank created this revision.Oct 16 2020, 3:07 PM

sashank edited the test plan for this revision. (Show Details)Oct 16 2020, 3:10 PM

lgtm

johann accepted this revision.Oct 16 2020, 3:13 PM

This revision is now accepted and ready to land.Oct 16 2020, 3:13 PM

Harbormaster failed remote builds in B19703: Diff 23916!Oct 16 2020, 3:30 PM

Harbormaster failed remote builds in B19706: Diff 23920!Oct 16 2020, 3:58 PM

Harbormaster completed remote builds in B19715: Diff 23929.Oct 16 2020, 4:26 PM

Closed by commit R1:82cc272fbfe0: [k8s] Allow users to set custom labels in Pod metadata (authored by sashank). · Explain WhyOct 16 2020, 4:30 PM

This revision was automatically updated to reflect the committed changes.

sashank added a commit: R1:82cc272fbfe0: [k8s] Allow users to set custom labels in Pod metadata.

Revision Contents
Changeset List

Path

Size

integration_tests/

test_suites/

k8s-integration-test-suite/

test_job_spec.py

5 lines

python_modules/

libraries/

dagster-k8s/

dagster_k8s/

job.py

8 lines

Diff 23920

View Options

integration_tests/test_suites/k8s-integration-test-suite/test_job_spec.py