Page MenuHomePhabricator
Differential D4796

Fix dagster_celery_docker
AbandonedPublic
Actions

Authored by dgibson on Oct 15 2020, 11:13 PM.

Details

Reviewers
johann
alangenfeld
Test Plan

BK

Diff Detail

Repository
R1 dagster
Branch
celerydockerfix (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

dgibson created this revision.Oct 15 2020, 11:13 PM
dgibson updated this revision to Diff 23831.Oct 15 2020, 11:27 PM

up

Harbormaster failed remote builds in B19619: Diff 23829!Oct 15 2020, 11:30 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 15 2020, 11:48 PM
Harbormaster failed remote builds in B19621: Diff 23831!
dgibson added reviewers: johann, alangenfeld.Oct 15 2020, 11:56 PM

Failure here is confusing: https://buildkite.com/dagster/dagster-diffs/builds/10164#a6918455-22ec-4e33-a02e-a8640a63b3cd

Lots of other modules are doing this (legacy_examples / airline_demo / etc.), not sure why adding one more would cause the port to be taken up?

dgibson updated this revision to Diff 23833.Oct 16 2020, 12:01 AM

Ah maybe this (pre-exit)? I'm confused why this would help though, the tests run in parallel don't they?

dgibson updated this revision to Diff 23834.Oct 16 2020, 12:01 AM

up

Harbormaster failed remote builds in B19623: Diff 23833!Oct 16 2020, 12:02 AM
dgibson updated this revision to Diff 23836.Oct 16 2020, 12:16 AM

shot in the dark

Harbormaster failed remote builds in B19624: Diff 23834!Oct 16 2020, 12:20 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 16 2020, 1:22 AM
Harbormaster failed remote builds in B19626: Diff 23836!
dgibson requested review of this revision.Oct 16 2020, 2:23 AM

halp

dgibson updated this revision to Diff 23844.Oct 16 2020, 2:38 AM

up

dgibson updated this revision to Diff 23845.Oct 16 2020, 2:55 AM

now it is passing, check for flakiness?

Harbormaster completed remote builds in B19634: Diff 23844.Oct 16 2020, 2:56 AM
Harbormaster completed remote builds in B19635: Diff 23845.Oct 16 2020, 3:13 AM
dgibson abandoned this revision.Oct 16 2020, 1:13 PM

rolling this into https://dagster.phacility.com/D4769

Revision Contents
Changeset List

PathSize
.buildkite/
hooks/
5 lines
14 lines
python_modules/
libraries/
dagster-celery-docker/
dagster_celery_docker_tests/
46 lines
2 lines

Diff 23845

View Options

.buildkite/hooks/pre-exit

Loading...
View Options

.buildkite/pipeline.py

Loading...
View Options

python_modules/libraries/dagster-celery-docker/dagster_celery_docker_tests/test_execute_docker.py

Loading...
View Options

python_modules/libraries/dagster-celery-docker/tox.ini

Loading...