Page MenuHomePhabricator

Fix dagster_celery_docker
AbandonedPublic

Authored by dgibson on Thu, Oct 15, 11:13 PM.

Details

Test Plan

BK

Diff Detail

Repository
R1 dagster
Branch
celerydockerfix (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Oct 15, 11:48 PM
Harbormaster failed remote builds in B19621: Diff 23831!

Failure here is confusing: https://buildkite.com/dagster/dagster-diffs/builds/10164#a6918455-22ec-4e33-a02e-a8640a63b3cd

Lots of other modules are doing this (legacy_examples / airline_demo / etc.), not sure why adding one more would cause the port to be taken up?

Ah maybe this (pre-exit)? I'm confused why this would help though, the tests run in parallel don't they?

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Oct 16, 1:22 AM
Harbormaster failed remote builds in B19626: Diff 23836!

now it is passing, check for flakiness?