Page MenuHomePhabricator

[dagit] Restore nav height fix for Safari
ClosedPublic

Authored by dish on Thu, Oct 15, 5:52 PM.

Details

Summary

Resolves #3106

Looks like I accidentally dropped the fix from https://github.com/dagster-io/dagster/commit/585b2130ee033fcbc666dac6dbd3b283c6f09f95 when creating TopNav. Restore it.

Test Plan

View Runs page in Safari, verify that the nav height stays correct. Shrink the window horizontally, verify that tabs wrap to the second line.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Thu, Oct 15, 5:57 PM
Harbormaster failed remote builds in B19567: Diff 23770!
dish requested review of this revision.Thu, Oct 15, 7:15 PM
This revision is now accepted and ready to land.Thu, Oct 15, 7:38 PM
This revision was automatically updated to reflect the committed changes.