Page MenuHomePhabricator

[dagit] Use parent snapshot ID to determine current-ness of snapshot
ClosedPublic

Authored by dish on Thu, Oct 15, 5:10 PM.

Details

Summary

In cases where a snapshot is a child of a parent snapshot, use that information to determine whether to tag the snapshot as "current". That is, if a parent snapshot is the current state of the pipeline, it should be labeled as "current".

  • Add nullable parentSnapshotId to PipelineSnapshot in GraphQL
  • Break apart PipelineNav
    • Query for parent snapshot in snapshot pipeline nav, with a brief loading state and a set width to avoid making the tabs jump
Test Plan

View snapshot pages for different pipelines, verify that the "current"/"snapshot" tag shows up correctly.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dish requested review of this revision.Thu, Oct 15, 5:30 PM
This revision is now accepted and ready to land.Thu, Oct 15, 7:41 PM

Show 'Snapshot' if there is no current pipeline state

This revision was landed with ongoing or failed builds.Thu, Oct 15, 8:11 PM
This revision was automatically updated to reflect the committed changes.