default to k8s scheduler, update docs
AbandonedPublic
Actions

Authored by catherinewu on Oct 14 2020, 4:11 PM.

Details

Reviewers

nate
johann
alangenfeld

Test Plan

Diff Detail

Repository

R1 dagster

Branch

default-k8s-scheduler

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

catherinewu created this revision.Oct 14 2020, 4:11 PM

Harbormaster completed remote builds in B19500: Diff 23689.Oct 14 2020, 4:29 PM

catherinewu requested review of this revision.Oct 14 2020, 4:29 PM

catherinewu added reviewers: nate, johann.Oct 14 2020, 4:53 PM

Harbormaster completed remote builds in B19504: Diff 23694.Oct 14 2020, 5:15 PM

catherinewu added a reviewer: alangenfeld.Oct 16 2020, 6:44 PM

I think this will be fine - unless someone deploys this change in a helm upgrade that somehow doesnt take down dagit running cron.

Should https://dagster.phacility.com/source/dagster/browse/master/helm/dagster/templates/deployment-dagit.yaml$54-59 get updated at all? Not a huge deal to be running cron if not needed - could prevent ^ if deployment spec changes

helm/dagster/values.yaml
157	hm, may need to come up with better names around this

alangenfeld accepted this revision.Oct 19 2020, 4:34 PM

This revision is now accepted and ready to land.Oct 19 2020, 4:34 PM

catherinewu abandoned this revision.Jan 14 2021, 12:22 AM

Revision Contents
Changeset List

Path

Size

docs/

next/

src/

pages/

deploying/

k8s_part2.mdx

9 lines

helm/

dagster/

values.yaml

4 lines

Diff 23694

View Options

docs/next/src/pages/deploying/k8s_part2.mdx