Page MenuHomePhabricator

default to k8s scheduler, update docs
AcceptedPublic

Authored by catherinewu on Wed, Oct 14, 4:11 PM.

Details

Test Plan

bk

Diff Detail

Repository
R1 dagster
Branch
default-k8s-scheduler
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

I think this will be fine - unless someone deploys this change in a helm upgrade that somehow doesnt take down dagit running cron.

Should https://dagster.phacility.com/source/dagster/browse/master/helm/dagster/templates/deployment-dagit.yaml$54-59 get updated at all? Not a huge deal to be running cron if not needed - could prevent ^ if deployment spec changes

helm/dagster/values.yaml
157

hm, may need to come up with better names around this

This revision is now accepted and ready to land.Mon, Oct 19, 4:34 PM