Page MenuHomePhabricator

add prefix to asset key query
ClosedPublic

Authored by prha on Tue, Oct 13, 9:22 PM.

Details

Summary

This will not improve the performance of the root asset catalog, but it will improve the performance of directly linked assets and asset directory paths

Test Plan

loaded direct linked asset page, saw prefix query instead of full asset query

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Oct 13, 9:25 PM
Harbormaster failed remote builds in B19467: Diff 23654!
prha requested review of this revision.Tue, Oct 13, 9:43 PM
alangenfeld added inline comments.
python_modules/dagster/dagster/core/storage/event_log/sql_event_log.py
406–414

This revision now requires changes to proceed.Wed, Oct 14, 7:58 PM
prha planned changes to this revision.Wed, Oct 14, 8:03 PM

refactor asset UI into root catalog, and a matching page, which first checks for exact asset key matches, and then falls back to a prefix search

This revision is now accepted and ready to land.Thu, Oct 15, 2:22 PM
This revision was automatically updated to reflect the committed changes.
prha marked an inline comment as done.