Page MenuHomePhabricator

remove selector from tutorial
ClosedPublic

Authored by sandyryza on Tue, Oct 13, 4:41 PM.

Details

Summary

This is motivated by a conversation I had with a confused user.

I don't mean to argue that we shouldn't have selector in the tutorial in general. But I think the way we introduce it causes confusion:

  • It's a tricky concept, and we introduce it in the same breath we're introducing a different tricky concept (dagster_type_loaders).
  • It's not actually necessary in the place where we introduce it. There's only one format to choose from, and there's no sub-config that depends on that format.
Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Oct 13, 5:09 PM
Harbormaster failed remote builds in B19437: Diff 23618!
Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Oct 13, 9:07 PM
Harbormaster failed remote builds in B19462: Diff 23649!
Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Oct 13, 9:47 PM
Harbormaster failed remote builds in B19470: Diff 23657!
sandyryza edited the test plan for this revision. (Show Details)

can you open an issue to intro selector in docs

This revision is now accepted and ready to land.Mon, Oct 19, 10:52 PM
This revision was automatically updated to reflect the committed changes.