Page MenuHomePhabricator

Refactor execute_step_with_structured_logs
AcceptedPublic

Authored by johann on Mon, Oct 12, 8:01 PM.

Details

Summary

Rename and remove args that can be gathered from the pipeline_run

Test Plan

celery k8s integration

Diff Detail

Repository
R1 dagster
Branch
refactor_execute_step (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

johann retitled this revision from modify execute_step args to Refactor execute_step_with_structured_logs.Mon, Oct 12, 8:12 PM
johann edited the summary of this revision. (Show Details)
johann edited the test plan for this revision. (Show Details)
johann added reviewers: alangenfeld, dgibson.
Harbormaster returned this revision to the author for changes because remote builds failed.Mon, Oct 12, 9:06 PM
Harbormaster failed remote builds in B19411: Diff 23587!

nice, this seems uncontroversial

This revision is now accepted and ready to land.Tue, Oct 13, 5:19 PM

if someone upgrade their user code but forgets to update the celery workers - how does this fail? We don't promise cross version compat so i think this "breaking" change is probably ok - as long as it fails in a clear way that someone knows what to do about it

python_modules/dagster/dagster/cli/api.py
400

and i think if we just kept this around that points directly at the new execute_step one, we may be totally fine

python_modules/dagster/dagster/grpc/types.py
52–56

due to how serdes works, I don't think this will be a problem