Page MenuHomeElementl

Add postgres DB container to celery docker test, fix api call escaping
ClosedPublic

Authored by dgibson on Oct 12 2020, 7:02 PM.

Diff Detail

Repository
R1 dagster
Branch
johanndiff
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 12 2020, 7:18 PM
Harbormaster failed remote builds in B19404: Diff 23579!

up, include johann's original diff too

Miraculously BK seems to be passing??

nice

python_modules/dagster-test/dagster_test/test_project/__init__.py
46

can you delete the other copy now that this one is more central?

python_modules/libraries/dagster-celery-docker/dagster_celery_docker/executor.py
63–68

we can deprecate / remove this

242

*

248

resolve

python_modules/dagster-test/dagster_test/test_project/__init__.py
46

it's not a copy, that is an ExternalPipeline, this is a ReconstructablePipeline. We could consolidate their locations though?

python_modules/dagster-test/dagster_test/test_project/__init__.py
46

ya lets keep our "yikes" together

maybe add a CHANGES.md entry about the breaking config changes in this diff so it doesn't get missed

This revision is now accepted and ready to land.Oct 13 2020, 7:27 PM

raise an error if nothing comes back from the command