Page MenuHomePhabricator

Add postgres DB container to celery docker test, fix api call escaping
ClosedPublic

Authored by dgibson on Mon, Oct 12, 7:02 PM.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mon, Oct 12, 7:18 PM
Harbormaster failed remote builds in B19404: Diff 23579!

up, include johann's original diff too

Miraculously BK seems to be passing??

nice

python_modules/dagster-test/dagster_test/test_project/__init__.py
45

can you delete the other copy now that this one is more central?

python_modules/libraries/dagster-celery-docker/dagster_celery_docker/executor.py
61–62

we can deprecate / remove this

223

*

229

resolve

python_modules/dagster-test/dagster_test/test_project/__init__.py
45

it's not a copy, that is an ExternalPipeline, this is a ReconstructablePipeline. We could consolidate their locations though?

python_modules/dagster-test/dagster_test/test_project/__init__.py
45

ya lets keep our "yikes" together

maybe add a CHANGES.md entry about the breaking config changes in this diff so it doesn't get missed

This revision is now accepted and ready to land.Tue, Oct 13, 7:27 PM

raise an error if nothing comes back from the command