Differential D4742 Authored by dgibson on Oct 9 2020, 2:46 PM.
Details Summary A whole bunch of our tests are using a format that goes through a deprecated loading process that's different than what we expect our users to use. This caused an issue in prod yesterday where dagster_docker_celery and certain dagster_airflow just stopped working. This diff replaces all the test yamls that were using it (other than ones specifically designed to test the legacy path), Test Plan BK+Azure
Diff Detail
Event TimelineHarbormaster returned this revision to the author for changes because remote builds failed.Oct 9 2020, 3:09 PM2020-10-09 15:09:18 (UTC+0) Harbormaster failed remote builds in B19363: Diff 23530!Oct 9 2020, 3:42 PM2020-10-09 15:42:01 (UTC+0) Harbormaster failed remote builds in B19364: Diff 23531!Oct 9 2020, 3:47 PM2020-10-09 15:47:12 (UTC+0) Harbormaster returned this revision to the author for changes because remote builds failed.Oct 9 2020, 4:05 PM2020-10-09 16:05:48 (UTC+0) Harbormaster returned this revision to the author for changes because remote builds failed.Oct 9 2020, 6:58 PM2020-10-09 18:58:13 (UTC+0) Harbormaster returned this revision to the author for changes because remote builds failed.Oct 9 2020, 7:54 PM2020-10-09 19:54:58 (UTC+0) Harbormaster failed remote builds in B19380: Diff 23551!Oct 9 2020, 8:31 PM2020-10-09 20:31:30 (UTC+0) Harbormaster returned this revision to the author for changes because remote builds failed.Oct 9 2020, 8:44 PM2020-10-09 20:44:18 (UTC+0) Comment Actions This fails only in celery-docker + airflow, as expected - johann's changes should sort those out Harbormaster returned this revision to the author for changes because remote builds failed.Oct 9 2020, 8:46 PM2020-10-09 20:46:33 (UTC+0)
Comment Actions This makes sense to land right before 0.10.0 just to put the breaking change in a major release. Ahead of removing support we should probably update all these callsites except for the explicit back compat test This revision now requires changes to proceed.Oct 12 2020, 8:02 PM2020-10-12 20:02:31 (UTC+0) dgibson retitled this revision from Remove legacy repo format from examples and loading path to Remove legacy repo format from examples/tests, replace the default with the new standard format except when specifically testing legacy stuff. Comment Actionsremove the breaking part, just update teh examples and tests for now Harbormaster completed remote builds in B19828: Diff 24055.Oct 20 2020, 1:57 AM2020-10-20 01:57:13 (UTC+0) This revision is now accepted and ready to land.Oct 20 2020, 7:48 PM2020-10-20 19:48:40 (UTC+0) Harbormaster completed remote builds in B19870: Diff 24110.Oct 20 2020, 8:11 PM2020-10-20 20:11:43 (UTC+0) Closed by commit R1:2d7d707fa3ad: Remove legacy repo format from examples/tests, replace the default with the new… (authored by dgibson). · Explain WhyOct 20 2020, 8:17 PM2020-10-20 20:17:09 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 23551 python_modules/dagster-graphql/dagster_graphql_tests/graphql/graphql_context_test_suite.pyLoading... python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_execution_plan.pyLoading... python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_execute_pipeline_in_hosted_user_process.pyLoading... python_modules/dagster/dagster_tests/cli_tests/workspace_tests/hello_world_in_file/test_hello_world_in_file_workspace.pyLoading... python_modules/dagster/dagster_tests/core_tests/launcher_tests/test_default_run_launcher.pyLoading... | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
