Page MenuHomePhabricator

Remove legacy repo format from examples/tests, replace the default with the new standard format except when specifically testing legacy stuff
ClosedPublic

Authored by dgibson on Fri, Oct 9, 2:46 PM.

Details

Summary

A whole bunch of our tests are using a format that goes through a deprecated loading process that's different than what we expect our users to use. This caused an issue in prod yesterday where dagster_docker_celery and certain dagster_airflow just stopped working.

This diff replaces all the test yamls that were using it (other than ones specifically designed to test the legacy path),

Test Plan

BK+Azure

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Oct 9, 3:09 PM
Harbormaster failed remote builds in B19362: Diff 23527!
Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Oct 9, 4:05 PM
Harbormaster failed remote builds in B19365: Diff 23532!
Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Oct 9, 6:58 PM
Harbormaster failed remote builds in B19375: Diff 23545!
Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Oct 9, 7:54 PM
Harbormaster failed remote builds in B19379: Diff 23550!
Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Oct 9, 8:44 PM
Harbormaster failed remote builds in B19381: Diff 23553!
dgibson added a reviewer: alangenfeld.

This fails only in celery-docker + airflow, as expected - johann's changes should sort those out

did not mean to abandon

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Oct 9, 8:46 PM
python_modules/dagster/dagster/cli/workspace/load.py
43–47 ↗(On Diff #23553)

everything in here stems from this one change :)

dgibson edited the summary of this revision. (Show Details)

This makes sense to land right before 0.10.0 just to put the breaking change in a major release. Ahead of removing support we should probably update all these callsites except for the explicit back compat test

This revision now requires changes to proceed.Mon, Oct 12, 8:02 PM
dgibson retitled this revision from Remove legacy repo format from examples and loading path to Remove legacy repo format from examples/tests, replace the default with the new standard format except when specifically testing legacy stuff.
dgibson edited the summary of this revision. (Show Details)

remove the breaking part, just update teh examples and tests for now

This revision is now accepted and ready to land.Tue, Oct 20, 7:48 PM