Page MenuHomePhabricator

[docs] execution overview
ClosedPublic

Authored by alangenfeld on Oct 8 2020, 7:17 PM.

Details

Diff Detail

Repository
R1 dagster
Branch
docs (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

sashank added inline comments.
docs/next/src/pages/overview/execution/index.mdx
24

Would be helpful to have a tiny code snippet here with a pipeline + solid and running both execute_pipeline and execute_solid with some run config.

This revision is now accepted and ready to land.Oct 8 2020, 8:29 PM
alangenfeld planned changes to this revision.

ok, i think this raises maybe more questions than it answers, but a viable placeholder

docs/next/src/pages/overview/execution/index.mdx
15

to interactively build up

27

full; also dangling " and"

35

probably clarify that this constructs an ephemeral pipeline

ok, i think this raises maybe more questions than it answers, but a viable placeholder

ideas for improvement? I think that in an overview it might be ok to have that vibe - provided we point you at the API docs or deeper explanations that answer those questions

will resolve inlines

up

docs/next/src/pages/overview/execution/index.mdx
43

@sashank i had to do dagster.core.instance to get this link to work even rebased on top of your recent move, not sure whats up with that

docs/next/src/pages/overview/execution/index.mdx
43

Ah you need to run make buildnext every time the sphinx docs change to pick it up. We have the following in the docs instructions, but let me know if there's a way to make this clearer/more obvious:

Also, make sure you rebase before running make buildnext I made a change to it yesterday that's important.

sashank resigned from this revision.EditedOct 27 2020, 11:02 PM

I'll let @max do the pass over the content – everything looks good except running make buildnext and changing the literal include from dagster.core.instance to dagster

we should just land this as an improvement over the status quo, sorry for holding it up for so long

This revision is now accepted and ready to land.Fri, Nov 6, 7:03 PM
This revision was automatically updated to reflect the committed changes.