If celery is disabled in helm values, we default to using the K8RunLauncher. Resolves https://github.com/dagster-io/dagster/issues/2611.
rexledesma on Oct 8 2020, 12:39 AM.Authored by
There are a very large number of changes, so older changes are hidden. Show Older Changes
looking good! few things (1) whats the reasoning behind adding "helm/dagster/templates/configmap-env-instance.yaml" instead of using "helm/dagster/templates/configmap-env-pipeline-run.yaml"? (2) in test_integration.py, could we assert that there are no celery worker pods and no step job pods? in a previous migration, there was a bad issue where the tests were no longer using the expected run launcher so would be nice to add a sanity check
It's kinda weird to have the launcher rely on the pipeline run configmap on when it might not even be configured if the user decides to go with user deployments. It would work, because the only purpose is to pass down some shared env variables, but the naming is off.
Honestly, I don't think some of these env variables (other than dagster home and the pg secret) should exist - they should just be interpolated via go template rather than set in the configmap.
sending back to your queue w/ a few things