Page MenuHomePhabricator

Revert "Revert "Add retries to dagster-postgres connections""
ClosedPublic

Authored by alangenfeld on Wed, Oct 7, 10:15 PM.

Details

Summary

AKA reland D4449

This reverted under the belief that it removed connection re-use which was inaccurate.

This diff does make things faster
{P102}

at least in the grpc case - since it prevents us from duping some connections when fetching run by id

speedscope without this

speedscope with this

This also helps get things moving in the right direction for actually sharing connections so better to keep it in.

This reverts commit f9bed241cece14bbd34f47e8ba72dfff111cafbe.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.