Page MenuHomePhabricator

[dagit] Don't crash on solid selection that isn't in subset
ClosedPublic

Authored by dish on Wed, Oct 7, 10:11 PM.

Details

Summary

Resolves #3026

When using the input to choose a solid subset, if a solid was previously selected but is not in the filtered subset, the page crashes.

Fix this by just not trying to render the selected solid.

Test Plan

View pipeline definition, choose subset, select a solid. Modify filter so that solid is no longer in the subset, verify that no errors occur.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dish edited the summary of this revision. (Show Details)EditedWed, Oct 7, 10:11 PM

This is an error that I would have expected sound typechecking to catch... [looks sideways at TypeScript]

dish requested review of this revision.Wed, Oct 7, 10:16 PM
This revision is now accepted and ready to land.Thu, Oct 8, 2:23 AM