Page MenuHomePhabricator

[dagit] print operation times
ClosedPublic

Authored by alangenfeld on Wed, Oct 7, 9:28 PM.

Details

Summary

print how long graphql requests took to come back

Test Plan

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alangenfeld added inline comments.
js_modules/dagit/src/index.tsx
57–78

we should probably gate this right? or do we let it be in users consoles so we can have them open it up when they have perf problems

We could add a debug console somewhere that allows toggling this kind of thing, then ask folks to toggle it on while we're live debugging with them.

Re: formatting I think it'd be nice to see the raw sec/msec value, 33.451s vs 0:33.

We could add a debug console somewhere that allows toggling this kind of thing, then ask folks to toggle it on while we're live debugging with them.

You can really easily add a client side feature flag here: js_modules/dagit/src/FeatureFlagsRoot.tsx. It shows up in the /flags route.

use feature flag to gate debug console logging

They probably doesn't add that much of a performance hit, but I wonder if we should conditionally include the logTimeLink and timeStartLink themselves based on the feature flag.

This revision is now accepted and ready to land.Thu, Oct 8, 4:18 PM
This revision was automatically updated to reflect the committed changes.