Page MenuHomePhabricator

[dagit] dont error on partition page load
ClosedPublic

Authored by alangenfeld on Wed, Oct 7, 8:51 PM.

Details

Summary

Would be nice to find a more clever solution to this problem when the repository context is not yet available so we return '' which will fail in the query we use it for. This skip trick has the right product behavior - but its easy to miss when it should be used.

Test Plan

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Seems like a spot where it would be good to have the repo and repo name up front in the URL.

This revision is now accepted and ready to land.Wed, Oct 7, 9:12 PM

Seems like a spot where it would be good to have the repo and repo name up front in the URL.

tru