Page MenuHomePhabricator

[dagit] Clarify snapshot ID in Runs table
ClosedPublic

Authored by dish on Wed, Oct 7, 7:23 PM.

Details

Summary

This diff proposes a few changes to the Runs table:

  • Unlink the pipeline name. This seems to be a point of confusion, where people want to click to the run itself, but instead click the pipeline name and end up on the pipeline instead.
  • Add a column that shows the snapshot ID for the run, linked to the snapshot -- this is the same href as the current pipeline name link, but aims to be clearer about linking to a snapshot.
  • Display a "historical" tag for historical snapshots, indicating when a run belongs to a stale pipeline snapshot.
Test Plan

View Runs page, verify behavior described above.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Open to thoughts/discussion!

dish requested review of this revision.Wed, Oct 7, 7:28 PM

iiinteresting - i like it. Curious what others think.

Another thing I'm wondering about: should "Open in Playground" and "Re-Execute" be available in the context menu for old runs whose snapshots are now historical? It seems like these links both end up applying the *current* pipeline state when I click them.

Unlink the pipeline name. This seems to be a point of confusion, where people want to click to the run itself, but instead click the pipeline name and end up on the pipeline instead.

I always do this - I've never clicked the run id on my first try. I'm still not sure if it's obvious that clicking the run id goes to the run. I wonder if it has to be more prominent, because that's the primary action users will want to take.

js_modules/dagit/src/runs/RunTable.tsx
106

Maybe "Pipeline Snapshot"?

should "Open in Playground" and "Re-Execute" be available in the context menu for old runs whose snapshots are now historical?

I'm not sure about "Re-Execute", but "Open in Playground" just copies the run config from the pipeline run into the playground. This is useful even if the pipeline snapshot has changed, but there's a chance that the run config is now invalid against the new pipeline. I'm not sure how to communicate that to users.

"Open in Playground" just copies the run config from the pipeline run into the playground

In the case of a historical config, would that mean that you get a config that might not work for the current pipeline at all but that that wouldn't be clear until you tried to run it?

js_modules/dagit/src/runs/RunTable.tsx
106

Sounds good. I did this initially but it required realigning the column header text so I punted, but I agree it's clearer.

In the case of a historical config, would that mean that you get a config that might not work for the current pipeline at all but that that wouldn't be clear until you tried to run it?

It would be clear in the playground, because you would see validation errors before you tried to run it. You can recreate this by running a pipeline, changing the config schema for one of the solids, and then clicking the "Open in Playground" button.

Interesting, so I would be re-executing the *config* with the *current* pipeline, not the config with the *historical* pipeline. Is that correct? Should I be able to execute the historical pipeline instead? (Is that allowed?)

Interesting, so I would be re-executing the *config* with the *current* pipeline, not the config with the *historical* pipeline. Is that correct? Should I be able to execute the historical pipeline instead? (Is that allowed?)

Yes that is correct. Currently there is no way to execute the historical pipeline at all. (It may be possible to in the future)

I think this is a great change—I know Prezi mentioned on the call last thursday that they click the pipeline name by accident too. I like the addition of the Historical tag and I think calling the column "Snapshot" makes it really clear that the underlying system is snapshotting your pipeline each time it's executed, which is cool and under-communicated in our old design. I think it'd be nice to make the click target a bit bigger by merging the run hash and the pipeline name into a single link but that's about it - big wins here!

This revision is now accepted and ready to land.Wed, Oct 7, 9:13 PM

I think it'd be nice to make the click target a bit bigger by merging the run hash and the pipeline name into a single link

This could be a nice way to increase information density -- I'll give it a try after this lands. Thanks!

This revision was automatically updated to reflect the committed changes.