Page MenuHomePhabricator

Allow querying runs by snapshot ID
ClosedPublic

Authored by dish on Tue, Oct 6, 10:39 PM.

Details

Summary

It is not currently possible to filter runs by snapshot ID, but it seems like this will be valuable for a Runs tab on historical snapshots.

Test Plan

Load GraphQL playground, use snapshotId filter.

query RunsQuery($filter: PipelineRunsFilter) {
  pipelineRunsOrError(filter: $filter) {
    ... on PipelineRuns {
      results {
        runId
        pipelineSnapshotId
      }
    }
  }
}

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Oct 6, 11:34 PM
Harbormaster failed remote builds in B19225: Diff 23362!

This looks good! It might be a good idea to add to the tests for this in /python_modules/dagster/dagster/utils/test/run_storage.py. The test_add_get_snapshot and test_fetch_by_pipeline methods should have all the logic you need.

Add test, generate types

dish requested review of this revision.Wed, Oct 7, 3:19 PM

redfordnod

ill let some else do the honors

This revision is now accepted and ready to land.Wed, Oct 7, 4:59 PM
This revision was automatically updated to reflect the committed changes.