Page MenuHomePhabricator

[core] remove execute_run_in_process
ClosedPublic

Authored by alangenfeld on Tue, Oct 6, 7:09 PM.

Details

Summary

This should be safe to remove now. Also removes DagitRemoteRunLauncher.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Oct 6, 7:29 PM
Harbormaster failed remote builds in B19203: Diff 23336!

mrburnsexcellent

My only question is that are we going to break anyone relying on the remote run launcher. Do need to go through a deprecation cycle?

My only question is that are we going to break anyone relying on the remote run launcher. Do need to go through a deprecation cycle?

Good question, I'm not sure if anyone is using it anymore. I think other changes have made the places this was used as a workaround go away.

python_modules/dagster-graphql/dagster_graphql/launcher/__init__.py
97–100

can maybe keep it around by changing this to launch run

i reached out to known users and they said they were no longer using it

This revision is now accepted and ready to land.Tue, Oct 13, 10:14 PM
This revision was automatically updated to reflect the committed changes.