Page MenuHomePhabricator

filter list_namespaced_job k8s call
ClosedPublic

Authored by johann on Mon, Oct 5, 6:29 PM.

Details

Summary

Do filtering on the API server rather than inside the client

Test Plan

todo

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sashank published this revision for review.Mon, Oct 5, 6:32 PM
python_modules/libraries/dagster-k8s/dagster_k8s/client.py
264–269

unsure about this - we should at least print the job names we got back or do a similar check to what we were doing before

This revision is now accepted and ready to land.Mon, Oct 5, 7:15 PM
This revision was automatically updated to reflect the committed changes.