Page MenuHomeElementl

Add Code Snippet for Metadata and custom Type Checks
AbandonedPublic

Authored by yichendai on Oct 2 2020, 5:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 16, 9:23 PM
Unknown Object (File)
Feb 17 2023, 12:33 AM
Unknown Object (File)
Feb 13 2023, 6:25 PM
Unknown Object (File)
Feb 13 2023, 4:45 AM
Unknown Object (File)
Feb 8 2023, 7:36 AM
Unknown Object (File)
Nov 26 2022, 1:35 AM
Unknown Object (File)
Nov 14 2022, 10:16 PM
Unknown Object (File)
Nov 13 2022, 10:46 AM
Subscribers
None

Details

Reviewers
max
Summary

Clarify what to provide in yaml for custom_types_4.py pipeline execution

Test Plan

Testing Changing tutorial

Testing Changing tutorial

Diff Detail

Repository
R1 dagster
Branch
rev6
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

max requested changes to this revision.Oct 2 2020, 6:01 PM
max added inline comments.
docs/next/src/pages/tutorial/types.mdx
257–262

missing period

258

"You can run this pipeline with config like the following:"

This revision now requires changes to proceed.Oct 2 2020, 6:01 PM

Rephrase

Updating D4645: Add Code Snippet for Metadata and custom Type Checks

max requested changes to this revision.Oct 7 2020, 2:49 PM

This is ok as a standalone change, req'ing changes for discussion. Do we want to provide config for *all* of the examples on this page? If not, why not? Seems inconsistent.

This revision now requires changes to proceed.Oct 7 2020, 2:49 PM
In D4645#126650, @max wrote:

Do we want to provide config for *all* of the examples on this page? If not, why not? Seems inconsistent.

I believe we should provide config explicitly for all the examples that ask the reader to run a pipeline (not limit to this page). For the readers' convenience, our plan can be providing the config code snippet in the paragraph, and linking the title of the pipeline script to the source code. In this case, the reader can change the steps of scrolling all the way up, going back to github and looking for both script and yaml files to going to the script directly and copying paste the config.