|1 ↗||(On Diff #23155)|
please replace existing image or delete it
this is fine as a standalone change, i am requesting changes just so we can discuss some of the broader issues. if we are going to use this green circle highlight idiom, we should use it elsewhere in the tutorial as well - it doesn't really make sense for this to be the only screenshot with salient elements highlighted. i also think we need a plan for how we're going to recreate these screenshots when the UI changes. the previous screenshots were generated automatically using a script: https://github.com/dagster-io/dagster/blob/master/docs/generate_screenshots.test.js -- if we aren't going to update this script to generate the highlights as well, i think we should consider writing instructions for whatever manual work is required to highlight the screenshots.
I totally agree with you on making all the UI uniform, but I'm not sure about generating them automatically by the script. We only need to make highlights for those concepts being introduced explicitly in the paragraph. The highlights will help the readers quickly become familiar with Dagit and some new concepts. I can read and note how much manual work are there.