Page MenuHomePhabricator

[dagit] show python error cause in log row
ClosedPublic

Authored by alangenfeld on Thu, Oct 1, 7:08 PM.

Details

Summary

The way things currently work is that the row for an error doesnt have the expand action if it doesn't overflow. This means that if there is a cause that we would show in the modal but the error is to short to overflow the log row, there is no way to get to the modal to see the exception.

This includes a cause section in the log row so that its is visible and more likley to overflow and make the modal available.

There might be a better systemic fix.

Test Plan

manual with updated error monster
[screenshot]

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nice catch. An alternative is always showing the expand button on errors but this is definitely easier.

This revision is now accepted and ready to land.Fri, Oct 2, 8:40 PM