Page MenuHomePhabricator

[dagit] Use Blueprint breadcrumbs and tabs for top nav
ClosedPublic

Authored by dish on Sep 30 2020, 10:23 PM.

Details

Summary
  • Create a breadcrumbed top nav component for use across pages in Dagit.
  • Use Blueprint tabs for the Pipeline view
Test Plan

Video attached.

Diff Detail

Repository
R1 dagster
Branch
dish-tabs (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

dish requested review of this revision.Sep 30 2020, 10:30 PM

i like it - will let the rest of the crew chime in

I think this is a clear improvement but will let @bengotow get his eyes on it before it gets merged.

This looks really solid! I think the consistency across schedules / assets is a huge win and this ended up being less code than I expected too! ๐Ÿ‘

This revision is now accepted and ready to land.Oct 5 2020, 7:23 PM
This revision was landed with ongoing or failed builds.Oct 5 2020, 8:20 PM
This revision was automatically updated to reflect the committed changes.