Page MenuHomePhabricator

Tweak the Gaant layout algorithm to arrange boxes better in Flat mode
ClosedPublic

Authored by bengotow on Sep 30 2020, 3:38 AM.

Details

Summary

This diff fixes two longstanding layout issues affecting the Gaant viz and also the left list of steps on the partition matrix:

  • The ordering of steps in "flat" mode is technically correct but didn't group chains of solids together. Re-ordering two steps of the algorithm makes this possible.
  • If steps were skipped, the "waterfall" (not timed) mode would present skipped steps on top of the executed steps rather than at the end of the chart.

I also incldued the chartjs types as a dev dependency because they are needed to fully introspect the options passed to our react-chartjs-2 components

Test Plan

Run tests

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 30 2020, 3:43 AM
Harbormaster failed remote builds in B18889: Diff 22942!
js_modules/dagit/src/gaant/GaantChartLayout.ts
132–137

what is 15 ? const-ify with a name maybe?

js_modules/dagit/src/gaant/GaantChartLayout.ts
132–137

Ahh yeah I will constify this, I think it's just a random inset that looked nice.

Constify FLAT_INSET_FROM_PARENT

defer to final review by @dish

This revision is now accepted and ready to land.Tue, Oct 6, 4:15 PM