Depends on D4562.
Details
Details
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Branch
- lakehouse-context (branched from master)
- Lint
Lint Passed - Unit
No Test Coverage
Event Timeline
Comment Actions
should we be more restrict to limit context to be a required arg and at the first position like all other decorators do?
Comment Actions
should we be more restrict to limit context to be a required arg and at the first position like all other decorators do?
I waffled on this a bit. Is there a particular reason you think it would better to make it required? The reason I ended up leaning in this direction is that my belief is that best practice for a lakehouse computation is _not_ to access the context - it makes it more likely that the user is accessing some external resource and making their code non-deterministic. It also means the computation is easy to test without providing a bunch of scaffolding.
Comment Actions
I kinda feel it's less robust to surface the variable by the literal arg name "context" and it could be consistent to all other entities (e.g. solid, resource, hook, etc) if the context is always the first positional arg.
my general sense was it's better to be restrict first and then lose the constraint than the opposite. I don't feel strongly about it in this case tho -- i trust your call