Page MenuHomePhabricator

add termination event for k8s launchers
ClosedPublic

Authored by catherinewu on Sun, Sep 27, 8:55 PM.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sun, Sep 27, 9:23 PM
Harbormaster failed remote builds in B18795: Diff 22819!

I think it makes sense to be more explicit in the messages about what is going on - can_terminate returned false, job delete request returned false etc

This revision is now accepted and ready to land.Mon, Sep 28, 8:48 PM