Page MenuHomePhabricator

RFC: lakehouse partitions
Changes PlannedPublic

Authored by sandyryza on Sep 25 2020, 11:38 PM.

Details

Reviewers
cdecarolis
yuhan
Test Plan

bk, used it for slack example

Diff Detail

Repository
R1 dagster
Branch
partition-lakehouse (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 25 2020, 11:53 PM
Harbormaster failed remote builds in B18780: Diff 22803!
python_modules/libraries/lakehouse/lakehouse/decorators.py
57

update docstring?

62–63

could you link an example to explain how the decorated func would look like?

107

update docstring?

136

worth writing docstring to explain the usage of num_base_args

python_modules/libraries/lakehouse/lakehouse/table.py
14–28

should we do type checks for the args?