Page MenuHomePhabricator

return [] instead of None in celery executor
ClosedPublic

Authored by catherinewu on Sep 24 2020, 4:42 AM.

Details

Test Plan

lines up with occurrence of error in python_modules/libraries/dagster-celery/dagster_celery/core_execution_loop.py", line 73, in core_celery_execution_loop. step_events = result.get() is None which is then iterated through #rip

todo: add a real test

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

catherinewu edited the test plan for this revision. (Show Details)
catherinewu added a reviewer: alangenfeld.

hate_computers

some day we will use a type checker and this flavor of BS will be caught by that

This revision is now accepted and ready to land.Sep 24 2020, 2:59 PM