Page MenuHomePhabricator

add ability to specify custom celery liveness probe
ClosedPublic

Authored by catherinewu on Sep 24 2020, 4:24 AM.

Details

Summary

Add the ability to specify custom celery liveness probe. Update the helm_chart in tests to use the default probe.

Test Plan

bk + testing helm install in eks cluster

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 24 2020, 5:25 AM
Harbormaster failed remote builds in B18653: Diff 22647!
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 24 2020, 8:02 AM
Harbormaster failed remote builds in B18656: Diff 22650!
catherinewu edited the test plan for this revision. (Show Details)

one nit, otherwise lgtm

python_modules/libraries/dagster-k8s/helm/dagster/values.yaml
255–256

Did you mean "If the set..."?

This revision is now accepted and ready to land.Sep 24 2020, 6:04 PM