Page MenuHomePhabricator

AssetMaterialization partitions
ClosedPublic

Authored by sandyryza on Sep 24 2020, 12:18 AM.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

i think this is legit, there is a high chance that partition_name might get replaced with if we decide to do multi-dimension partitioning, but the back compat story is clear cut so not a big deal.

sandyryza retitled this revision from RFC: AssetMaterialization partitions to AssetMaterialization partitions.Sep 26 2020, 12:28 AM
sandyryza retitled this revision from AssetMaterialization partitions to RFC: AssetMaterialization partitions.
sandyryza retitled this revision from RFC: AssetMaterialization partitions to AssetMaterialization partitions.Tue, Sep 29, 3:44 PM
python_modules/dagster-graphql/dagster_graphql/schema/assets.py
92

can event_specific_data or event_specific_data.materialization be null? shall we check if the event is an asset materialization event either here or in the init?

python_modules/dagster-graphql/dagster_graphql/schema/assets.py
92

It definitely should not be null, but I'll add a check to help make sure.

Could be partition instead of partition_name.

This looks great. Excited to see where this goes.

python_modules/dagster-graphql/dagster_graphql/schema/assets.py
35

comma?

This revision is now accepted and ready to land.Wed, Sep 30, 11:06 PM

Could be partition instead of partition_name.

partition it is

This revision was automatically updated to reflect the committed changes.