Page MenuHomePhabricator

Add comments to GraphQL definitions of execution params / metadata
ClosedPublic

Authored by bengotow on Sep 17 2020, 8:16 PM.

Details

Summary

After talking with Yuhan yesterday I thought it might be helpful to translate my notes into comments on the GraphQL schema that are visible in GraphiQL. These could probably use even more detail, but the key things I wanted to add are:

  • All re-executions are implicitly scoped by the pipeline solid subset.
  • Passing stepKeys: null, stepKeys: [] and stepKeys: [every key..] are equivalent
  • Indicating restart from failure via the special dagster tag overrides stepKeys

Test Plan

Read new comments

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 17 2020, 8:30 PM
Harbormaster failed remote builds in B18418: Diff 22361!
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 18 2020, 4:04 AM
Harbormaster failed remote builds in B18448: Diff 22396!

Force wrap, black complains but does not fix

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 18 2020, 3:20 PM
Harbormaster failed remote builds in B18459: Diff 22409!
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 18 2020, 4:00 PM
Harbormaster failed remote builds in B18470: Diff 22422!

nice!
the error in bk was fixed last friday afternoon so it should pass once you rebase

This revision is now accepted and ready to land.Sep 23 2020, 5:11 AM