Page MenuHomePhabricator

Use react-router Link for nav
ClosedPublic

Authored by dish on Sep 17 2020, 7:43 PM.

Details

Summary

Use react-router-dom's Link component for the top nav tabs instead of div elements with onClick.

After this, I'll put up a diff that allows disabling the nav items as needed.

Stacked on D4459.

Test Plan

Verify proper rendering, behavior, and navigation of nav link items.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 17 2020, 7:57 PM
Harbormaster failed remote builds in B18414: Diff 22356!
dish requested review of this revision.Sep 17 2020, 10:58 PM
This revision is now accepted and ready to land.Sep 18 2020, 3:47 PM
This revision was automatically updated to reflect the committed changes.