Page MenuHomePhabricator

Don't show snapshot banner for current pipeline
ClosedPublic

Authored by dish on Sep 17 2020, 6:15 PM.

Details

Summary

The historical snapshot banner appears on the pipeline display when loading a specific run, even when the relevant pipeline is current.

Check the ID in the URL path against the ID of the pipeline, and if they match, don't show the banner.

Test Plan

Run a pipeline. Change the pipeline solids, run it again. View each run, verify that the stale pipeline run shows the banner but that the current one does not.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 17 2020, 6:30 PM
Harbormaster failed remote builds in B18405: Diff 22345!
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 17 2020, 7:53 PM
Harbormaster failed remote builds in B18412: Diff 22354!
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 17 2020, 8:22 PM
Harbormaster failed remote builds in B18417: Diff 22360!
dish requested review of this revision.Sep 17 2020, 8:34 PM

Can't seem to get the build to behave because of version mismatching, requesting review manually.

This revision is now accepted and ready to land.Sep 17 2020, 10:00 PM
This revision was landed with ongoing or failed builds.Sep 17 2020, 10:38 PM
This revision was automatically updated to reflect the committed changes.