Page MenuHomePhabricator

Show error toast on termination PythonError
ClosedPublic

Authored by dish on Sep 16 2020, 11:08 PM.

Details

Summary

When a Python error is raised when terminating a run, the "Terminate" button doesn't appear to do anything and no error is surfaced.

Resolve this by ensuring that the PythonError is also handled in the mutation.

Resolves #2688

Test Plan

Run an intentionally slow pipeline, with a raise Exception('oh no') in the termination codepath. Click "Terminate", verify that the error toast appears.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 16 2020, 11:30 PM
Harbormaster failed remote builds in B18392: Diff 22326!
dish requested review of this revision.Sep 17 2020, 2:13 PM
This revision is now accepted and ready to land.Sep 17 2020, 4:00 PM
This revision was automatically updated to reflect the committed changes.

might be nice if we could surface a stack trace (and maybe cause) for the PythonError since that means something unexpected went wrong and debugging is likely necessary

Yeah, @catherinewu and I were talking about that too.

The toast seems like an obvious place to put a link to show e.g. a dialog with the stack trace, but the toast fades away, which is awkward if you need the debugging info. I can look into whether the toast can be prevented from fading away.

Replacing the toast with a dialog might also work.