Page MenuHomePhabricator

Remove create_clean_storage
Changes PlannedPublicDraft

Authored by nate on Sep 16 2020, 9:55 PM.

Details

Reviewers
alangenfeld
max
Summary

Instead of maintaining two different implementations for wiping pg storage, this removes create_clean_storage (which was only used in tests anyway) and uses the wipe() method directly.

Depends on D4449

Test Plan

unit

Diff Detail

Repository
R1 dagster
Branch
cleanup_create_clean_storage
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 16 2020, 10:15 PM
Harbormaster failed remote builds in B18385: Diff 22318!
nate added reviewers: alangenfeld, max.
nate added inline comments.
python_modules/dagster/dagster/core/storage/event_log/sql_event_log.py
285–286

ensures we do the right thing even if more tables are added in the future

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 16 2020, 11:26 PM
Harbormaster failed remote builds in B18391: Diff 22325!