Page MenuHomePhabricator

Enable import/order
ClosedPublic

Authored by dish on Sep 16 2020, 4:21 PM.

Details

Summary

Enable import/order in eslint config, with alphabetization turned on.

Import organization is one of those things that bizarrely takes up more time and thought than it should (none), so let's make it automatic.

Also removed a couple of off entries that don't currently trigger anything.

Test Plan

Lint, ts, jest.

Diff Detail

Repository
R1 dagster
Branch
dish-import-order (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 16 2020, 4:36 PM
Harbormaster failed remote builds in B18360: Diff 22285!
dish requested review of this revision.Sep 16 2020, 4:52 PM

Passing build after a granular manual retry.

This revision is now accepted and ready to land.Sep 16 2020, 5:56 PM
This revision was landed with ongoing or failed builds.Sep 16 2020, 5:59 PM
Closed by commit R1:2d43725ee136: Enable import/order (authored by dish). · Explain Why
This revision was automatically updated to reflect the committed changes.