Page MenuHomePhabricator

Upgrade react-scripts, eslint
ClosedPublic

Authored by dish on Sep 15 2020, 10:08 PM.

Details

Summary

A few upgrades while I'm in here, to react-scripts and eslint and its associates.

There are a few eslint rules I'd like to fiddle around with once this lands, but in the meantime only two warnings (react-hooks deps lists) cropped up, so I fixed them.

Test Plan

Lint, jest.

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 15 2020, 10:21 PM
Harbormaster failed remote builds in B18339: Diff 22260!
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 15 2020, 10:43 PM
Harbormaster failed remote builds in B18342: Diff 22264!
dish requested review of this revision.Sep 16 2020, 2:13 AM
This revision is now accepted and ready to land.Sep 16 2020, 3:12 PM
prha added inline comments.
js_modules/dagit/src/TokenizingField.tsx
92

what's the value of using useMemo here?

js_modules/dagit/src/TokenizingField.tsx
92

There was a lint warning associated with it, triggered by turning suggestions into a useMemo below and including values in the dependencies array. The warning was that because values is a newly created array on every render, the useMemo function would always execute.

The same warning had surfaced for suggestions, which is why I converted it to useMemo...which then surfaced this one too.

js_modules/dagit/src/TokenizingField.tsx
92

๐Ÿ‘

This revision was automatically updated to reflect the committed changes.